Correct Babel dependency behavior #5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@babel/plugin-transform-runtime will try to insert Before Babel: async function fn() {}
module.exports = fn;After Babel: import _regeneratorRuntime from "@babel/runtime/regenerator";
import _asyncToGenerator from "@babel/runtime/helpers/asyncToGenerator";
// ...
module.exports = fn;Mixing commonjs modules and es modules will cause webpack to generate invalid code. |
|
Hmm, thank you for the information @lixiaoyan. |
|
@Timer Set |
|
Awesome @lixiaoyan. Mind sending a PR changing this or do you not care for the git blame? |
|
Even prepped the diff for you: diff --git a/packages/react-scripts/config/webpack.config.dev.js b/packages/react-scripts/config/webpack.config.dev.js
index 12b8f8cf..0775b62a 100644
--- a/packages/react-scripts/config/webpack.config.dev.js
+++ b/packages/react-scripts/config/webpack.config.dev.js
@@ -277,6 +277,11 @@ module.exports = {
],
cacheDirectory: true,
highlightCode: true,
+ // Babel assumes ES Modules, which isn't safe until CommonJS
+ // dies. This changes the behavior to assume CommonJS unless
+ // an `import` or `export` is present in the file.
+ // https://github.com/webpack/webpack/issues/4039#issuecomment-419284940
+ sourceType: 'unambiguous',
},
},
],
diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js
index 1e0fadbf..6c44af5c 100644
--- a/packages/react-scripts/config/webpack.config.prod.js
+++ b/packages/react-scripts/config/webpack.config.prod.js
@@ -306,6 +306,11 @@ module.exports = {
],
cacheDirectory: true,
highlightCode: true,
+ // Babel assumes ES Modules, which isn't safe until CommonJS
+ // dies. This changes the behavior to assume CommonJS unless
+ // an `import` or `export` is present in the file.
+ // https://github.com/webpack/webpack/issues/4039#issuecomment-419284940
+ sourceType: 'unambiguous',
},
},
], |
lixiaoyan
added a commit
to lixiaoyan/create-react-app
that referenced
this pull request
Sep 21, 2018
|
I think the best place to add this option is "babel-preset-react-app/dependencies.js" (it just works). |
Timer
pushed a commit
that referenced
this pull request
Sep 21, 2018
|
Makes sense. PR merged. 🎉 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babel was compiling async/generators incorrectly in dependency using just
preset-env. We need to rewrite these to use the non-global regenerator and apply other tweaks from the application configuration.On a side note, it took me forever to figure out there was some bad actor in Yarn Workspaces/Babel that required me to
git clean -fdx && yarn installevery time I changeddependencies.js. Troubleshooting this took ages because of that.